Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/824#discussion_r115104954
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -526,6 +534,48 @@ private void writeFile(ParquetTableMetadataDirs
parquetTableMetadataDirs, Path p
}
/**
+ * Serializer for ParquetPath. Writes the path relative to the root path
+ */
--- End diff --
Why compute the relative during serialization? A more common approach is to
store the relative paths in our internal data structures and serialize that
relative value.
Doing things this way is awkward: we need to define a serializer and
deserializer unnecessarily.
Also, see comment later on backward compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
