Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/809#discussion_r114778278
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -495,26 +612,45 @@ connectionStatus_t
DrillClientImpl::handleAuthentication(const DrillUserProperti
}
}
+ std::stringstream errorMsg;
--- End diff --
"logMsg" would be a better name than "errorMsg" because this is also used
in a successful path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
