Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/827#discussion_r115545110
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/provider/LocalPersistentStoreProvider.java
---
@@ -57,14 +59,14 @@ public LocalPersistentStoreProvider(final DrillConfig
config) throws StoreExcept
}
@Override
- public <V> PersistentStore<V> getOrCreateStore(PersistentStoreConfig<V>
storeConfig) {
+ public <V> PersistentStore<V> getOrCreateStore(PersistentStoreConfig<V>
storeConfig) throws StoreException {
switch(storeConfig.getMode()){
case BLOB_PERSISTENT:
case PERSISTENT:
- if (enableWrite) {
+ if (!useEphemeral) {
--- End diff --
yes, ephemeral write should be false by default. For backward
compatibility, we should probably just stick with local write i.e. trigger
ephemeral write when local write is false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
