Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/823#discussion_r116335475
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/PhysicalOpUnitTestBase.java
 ---
    @@ -82,6 +81,8 @@
      * Look! Doesn't extend BaseTestQuery!!
      */
     public class PhysicalOpUnitTestBase extends ExecTest {
    +  public static long INIT_ALLOCATION = 10_000_000l;
    +  public static long MAX_ALLOCATION = 15_000_000L;
    --- End diff --
    
    I adopted the suggested code refactoring in AbstractBase, and use the two 
constant values there. 
    
    I also set maxAllocation to 15M for 
BasicPhysicalOpUnitTest.testExternalSort(), since 15M was the original value 
Jason used for that testcase, and using the default 10M would cause OOM for 
that testcase. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to