Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r117106477
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatch.java ---
@@ -188,6 +188,18 @@
NOT_YET,
/**
+ * Restart reading incoming batches.
+ * <p>
+ * Prior calls to {@link #next()} returned data after all incoming
batches were processed.
+ * But with this status, need to restart reading incoming
RecordBatches.
+ * </p>
+ * <p>
+ * Currently only used internally by the Hash Aggregate.
+ * </p>
+ */
--- End diff --
Not entirely sure we want to extend the core Volcano iterator protocol to
help with a single operator. In general, ALL operators should be prepared to
handle this value since it is part of the public protocol.
Can we find a way to avoid this? I suspect some code restructuring, along
with an operator-specific enum, would do the trick.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
