Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/838#discussion_r117532070
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 
---
    @@ -213,17 +213,16 @@ public IterOutcome next() {
               try {
                 currentReader.allocate(mutator.fieldVectorMap());
               } catch (OutOfMemoryException e) {
    -            logger.debug("Caught OutOfMemoryException");
                 clearFieldVectorMap();
    -            return IterOutcome.OUT_OF_MEMORY;
    +            throw UserException.memoryError(e).build(logger);
               }
               addImplicitVectors();
             } catch (ExecutionSetupException e) {
    -          this.context.fail(e);
    --- End diff --
    
    This call triggers query failure (stopping the fragment, notifying the 
Foreman, and cancelling other fragments, etc.). What is the flow after this 
change?
    
    Similar changes below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to