Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r117862000
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
 ---
    @@ -546,44 +1254,204 @@ private void checkGroupAndAggrValues(int 
incomingRowIdx) {
          holder.value = vv0.getAccessor().get(incomingRowIdx) ;
          }
          */
    +    /*
    +    if ( handlingSpills && ( incomingRowIdx == 0 ) ) {
    --- End diff --
    
    This debugging code is written for a specific schema 
(VarChar,VarChar,Bigint); placing it inside EXTRA_DEBUG_1 may create the 
impression that it is a generic debug code. Leaving it as a comment/sample 
allows for easy rewriting to print out data (of any other schema).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to