Github user tdunning commented on a diff in the pull request:

    https://github.com/apache/drill/pull/831#discussion_r118397540
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Murmur128.java
 ---
    @@ -0,0 +1,161 @@
    +/*
    --- End diff --
    
    I tried to merge them, but the assumptions of working on unsafe code were 
very difficult to remove. I also had a difficult time figuring out a useful API.
    
    Happy to look at specific suggestions, but the way that the existing 
implementation always iterates through unsafe pointers meant that there is 
likely to be nearly no shared code. Merging by simply moving my methods to the 
existing implementation is certainly doable.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to