Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r118813700
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -306,14 +685,29 @@ public AggOutcome doWork() {
while (true) {
// Cleanup the previous batch since we are done processing it.
+ long pre = allocator.getAllocatedMemory();
for (VectorWrapper<?> v : incoming) {
v.getValueVector().clear();
}
+ long beforeAlloc = allocator.getAllocatedMemory();
+
--- End diff --
This function seems overly long: very hard to follow. Perhaps break out
each nested loop into a function. Since the functions are called once per
batch, the cost of a function call is lost in the noise of operating the
iterator hierarchy. The gain, however, is lower mental cost to understand
what's happening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
