Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/847#discussion_r120474915
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
---
@@ -462,7 +431,10 @@ public Void call() throws IOException {
readStatus.setDiskScanTime(timeToRead);
assert (totalValuesRead <= totalValuesCount);
}
- synchronized (queue) {
+ // FindBugs reports this is a possible bug, but it is not. You do
need the synchronized block
--- End diff --
I'd intended to suppress the warning initially, but then got rid of it by
using a different object to synchronize on. Fixed the comment to not refer to
FindBugs though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
