Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/805#discussion_r126568096
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
---
@@ -181,6 +186,101 @@ else if (parquetTableMetadata instanceof
Metadata.ParquetTableMetadata_v2 &&
}
/**
+ * Checks that the metadata file has version less than
+ * the version where was changed the serialization of BINARY values
+ * and assigns byte arrays to min/max values obtained from the
deserialized string.
+ *
+ * @param parquetTableMetadata table metadata that should be corrected
+ */
--- End diff --
This is very hard to follow for those of us not familiar with the details
of the metadata file format. Please include a comment in the PR conversation
that shows an example of the old and new formats. That will make it easy to
double-check that the logic makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
