Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r123839714
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -139,14 +184,16 @@ public String toString() {
*/
private int rowCount;
/**
- * Standard row width using Drill meta-data.
+ * Standard row width using Drill meta-data. Note: this information is
+ * 100% bogus. Do not use it.
*/
+ @Deprecated
private int stdRowWidth;
--- End diff --
Can just eliminate this field (and the method stdRowWidth() ). It is only
being used by the HashAgg, but that code there is dead anyway, as it only
applies for rowCount() == 0 , which is false as the method
updateEstMaxBatchSize() is only called for a non-empty batch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
