The only trick I see is that you have to do the “add then take away” dance. Add the dependencies where needed. But, then exclude them from the jdbc-all project.
Code added would, I imagine, need a license compatible with the Apache license. Parth seems to know a bit more about this aspect, perhaps he can shed some light? - Paul > On Jul 21, 2017, at 9:30 AM, Charles Givre <[email protected]> wrote: > > I have two collections of functions which I'd like to submit for the next > version of Drill and they have dependencies on apache commons libraries. > The first is a collection of network related functions ( > https://github.com/cgivre/drill-network-functions) and the other is a > collection of functions that are useful for approximate string matching. ( > https://github.com/cgivre/drill-phonetic-functions) > > I have to clean up the code and finish the documentation, but I'm planning > on submitting for the next version of Drill. > --C > > > > > > On Fri, Jul 21, 2017 at 12:20 PM, Kunal Khatua <[email protected]> wrote: > >> As long as the dependencies don't create conflict with existing >> dependencies, I don’t see a strong reason to "frown upon" such additions. >> >> I know there are a fair amount of dependencies that could do with an >> update, but might have been put off because of the core engine not ready as >> yet for some of those changes. >> >> Can you share more details about what are the dependencies? >> >> ~ Kunal >> >> -----Original Message----- >> From: Charles Givre [mailto:[email protected]] >> Sent: Friday, July 21, 2017 8:18 AM >> To: dev <[email protected]> >> Subject: Dependency Question >> >> Hello all, >> I'm interested in submitting some PRs for additional UDFs and some other >> functionality and I'm curious as to the project's attitude to adding >> additional dependencies to Drill. (Within reason) Is it "frowned upon" to >> add dependencies? >> Does it matter? >> Thanks, >> - C >>
