Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r130991076
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java
---
@@ -495,14 +495,14 @@ public void testFutureUnsupportedMetadataVersion()
throws Exception {
try {
test("use dfs_test.tmp");
test("create table `%s` as select * from cp.`tpch/nation.parquet`",
unsupportedMetadataVersion);
- String lastVersion =
Iterables.getLast(MetadataVersion.Constants.SUPPORTED_VERSIONS);
- for (String supportedVersion :
MetadataVersion.Constants.SUPPORTED_VERSIONS) {
- if (new MetadataVersion(lastVersion).compareTo(new
MetadataVersion(supportedVersion)) < 0) {
+ MetadataVersion lastVersion =
Iterables.getLast(MetadataVersion.Constants.SUPPORTED_VERSIONS);
+ for (MetadataVersion supportedVersion :
MetadataVersion.Constants.SUPPORTED_VERSIONS) {
+ if (lastVersion.compareTo(supportedVersion) < 0) {
lastVersion = supportedVersion;
}
}
// Get the future version, which is absent in
MetadataVersion.SUPPORTED_VERSIONS list
- String futureVersion = "v" +
(Integer.parseInt(String.valueOf(lastVersion.charAt(1))) + 1);
+ String futureVersion = "v" +
(Integer.parseInt(String.valueOf(lastVersion.toString().charAt(1))) + 1);
--- End diff --
This code was replaced since float metadata versions are introduced.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
