Thanks for the advice ,will consider that. On Mon, 14 Aug 2017 at 7:56 PM vvysotskyi <[email protected]> wrote:
> Github user vvysotskyi commented on a diff in the pull request: > > https://github.com/apache/drill/pull/904#discussion_r132932858 > > --- Diff: > exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/DateToCharFunctions.java > --- > @@ -65,7 +65,7 @@ public void setup() { > byte[] buf = new byte[right.end - right.start]; > right.buffer.getBytes(right.start, buf, 0, right.end - > right.start); > String input = new String(buf, > com.google.common.base.Charsets.UTF_8); > - format = > org.joda.time.format.DateTimeFormat.forPattern(input); > + format = > org.joda.time.format.DateTimeFormat.forPattern(input).withLocale(java.util.Locale.ENGLISH); > --- End diff -- > > I don't think that it is the right solution. A table may contain a > field with date strings which were created with the non-ENGLISH locale so > for this case, the query will fail. > > We need to set locale to ENGLISH only for required unit tests. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > --- >
