Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/907#discussion_r134035974
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
 ---
    @@ -157,6 +157,967 @@ public void testRegexpReplace() throws Exception {
       }
     
       @Test
    +  public void testLikeStartsWith() throws Exception {
    +
    +    // all ASCII.
    +    testBuilder()
    --- End diff --
    
    The regex parsing and execution code is becoming complex. Let's test it 
with a true unit test, not just a system-level test using a query. See the test 
frameworks available. We can also discuss in person.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to