Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/906#discussion_r135574741
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillScanRel.java
---
@@ -160,12 +161,7 @@ public RelOptCost computeSelfCost(final RelOptPlanner
planner, RelMetadataQuery
final ScanStats stats = groupScan.getScanStats(settings);
int columnCount = getRowType().getFieldCount();
double ioCost = 0;
- boolean isStarQuery = Iterables.tryFind(getRowType().getFieldNames(),
new Predicate<String>() {
- @Override
- public boolean apply(String input) {
- return Preconditions.checkNotNull(input).equals("*");
- }
- }).isPresent();
+ boolean isStarQuery = AbstractRecordReader.isStarQuery(columns);
--- End diff --
Should this planning-time class depend on a specific execution-time class?
Or, would it be better to move the method from the execution class onto
something common between plan and execution?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
