Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/906#discussion_r135925006
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
 ---
    @@ -768,4 +765,73 @@ else if (exprHasPrefix && refHasPrefix) {
           }
         }
       }
    +
    +  /**
    +   * handle FAST NONE specially when Project for query output. This 
happens when input returns a
    --- End diff --
    
    I change to "handleNullInput" from "handleFastNone". 
    
    The concept of "NullInput" captures the scenarios where input does not 
produce any batch, and returning NONE directly.  The concept of "empty result 
set" could mean the case where we have 0 row, but still we could have a batch. 
I think "empty result set" is not precisely what we want to cover here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to