[GitHub] drill issue #938: DRILL-5694: Handle HashAgg OOM by spill and retry, plus pe...

[Ben-Zvi]

Github user Ben-Zvi commented on the issue:

    https://github.com/apache/drill/pull/938
  
      These tests passed for me (embedded, on the Mac) after squashing and 
rebasing yesterday.
    
    Were these failures seen on the cluster ?
    
    The test that "failed" was supposed to hit a failure internally (user error 
- not enough memory).
    
    
    
    ________________________________
    From: Paul Rogers <notificati...@github.com>
    Sent: Thursday, September 21, 2017 10:03:57 PM
    To: apache/drill
    Cc: Boaz Ben-Zvi; Mention
    Subject: Re: [apache/drill] DRILL-5694: Handle HashAgg OOM by spill and 
retry, plus perf improvement (#938)
    
    
    @Ben-Zvi<https://github.com/ben-zvi>, unit tests failed with these errors:
    
    Failed tests:
      TestHashAggrSpill.testHashAggrFailWithFallbackDisabed:165 null
    
    Tests in error:
      TestHashAggrSpill.testNoPredictHashAggrSpill:135->testSpill:110 » 
IllegalState
      TestHashAggrSpill.testHashAggrSecondaryTertiarySpill:147->testSpill:110 
» IllegalState
      TestHashAggrSpill.testSimpleHashAggrSpill:123->testSpill:110 » 
IllegalState Cl...
      
TestHashAggrSpill.testHashAggrSuccessWithFallbackEnabled:179->testSpill:110 » 
IllegalState
    
    
    Is this expected at this stage? Are these due to the test framework issue 
we discussed recently?
    
    —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on 
GitHub<https://github.com/apache/drill/pull/938#issuecomment-331350881>, or 
mute the 
thread<https://github.com/notifications/unsubscribe-auth/AFNkR8EwAcVMU_x3rbfQNjKDs3GvNhkxks5skz-8gaJpZM4PR2ky>.



---