Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/957#discussion_r140936599
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/server/options/PersistedOptionValueTest.java
 ---
    @@ -0,0 +1,226 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.drill.exec.server.options;
    +
    +import com.fasterxml.jackson.annotation.JsonInclude;
    +import com.fasterxml.jackson.annotation.JsonProperty;
    +import com.fasterxml.jackson.databind.ObjectMapper;
    +import org.apache.drill.common.util.FileUtils;
    +import org.apache.drill.exec.serialization.JacksonSerializer;
    +import org.apache.drill.exec.store.sys.PersistentStoreConfig;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import java.io.IOException;
    +
    +public class PersistedOptionValueTest {
    +  /**
    +   * DRILL-5809
    +   * Note: If this test breaks you are probably breaking backward and 
forward compatibility. Verify with the community
    --- End diff --
    
    Great comment!


---

Reply via email to