Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r142667318
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java ---
@@ -132,38 +173,47 @@ public void submitQuery(UserResultsListener
resultsListener, RunQuery query) {
/**
* Connects, and if required, authenticates. This method blocks until
both operations are complete.
*
- * @param endpoint endpoint to connect to
- * @param properties properties
+ * @param endpoint endpoint to connect to
+ * @param properties properties
* @param credentials credentials
* @throws RpcException if either connection or authentication fails
*/
public void connect(final DrillbitEndpoint endpoint, final
DrillProperties properties,
- final UserCredentials credentials) throws
RpcException {
- final UserToBitHandshake.Builder hsBuilder =
UserToBitHandshake.newBuilder()
- .setRpcVersion(UserRpcConfig.RPC_VERSION)
- .setSupportListening(true)
- .setSupportComplexTypes(supportComplexTypes)
- .setSupportTimeout(true)
- .setCredentials(credentials)
- .setClientInfos(UserRpcUtils.getRpcEndpointInfos(clientName))
- .setSaslSupport(SaslSupport.SASL_PRIVACY)
- .setProperties(properties.serializeForServer());
+ final UserCredentials credentials) throws RpcException {
+ final UserToBitHandshake.Builder hsBuilder =
+
UserToBitHandshake.newBuilder().setRpcVersion(UserRpcConfig.RPC_VERSION).setSupportListening(true)
--- End diff --
Having each parameter assignment on separate line was more readable...
---
