Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/997#discussion_r145319760 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -145,6 +145,8 @@ int SaslAuthenticatorImpl::init(const std::vector<std::string>& mechanisms, exec authMechanismToUse = value; } } + // clientNeedsAuth cannot be false if the code above picks an authMechanism --- End diff -- clientNeedsAuth --> clientNeedsAuthentication
---