Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/993#discussion_r145565968
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java
 ---
    @@ -260,8 +282,14 @@ public WebUserConnection provide() {
             logger.trace("Failed to get the remote address of the http session 
request", ex);
           }
     
    -      final WebSessionResources webSessionResources = new 
WebSessionResources(sessionAllocator,
    -              remoteAddress, drillUserSession);
    +      // Create a dummy close future which is needed by Foreman only. 
Foreman uses this future to add a close
    +      // listener to known about channel close event from underlying 
layer. We use this future to notify Foreman
    +      // listeners when the Web connection between Web Client and 
WebServer is closed. This will help Foreman to cancel
    --- End diff --
    
    Will fix the comment


---

Reply via email to