Github user sachouche commented on the issue:
https://github.com/apache/drill/pull/1001
Paul,
- I think you misunderstood the proposal
- Let me use an example
- select .. c1 like '%pattern1%' OR c1 like '%pattern2'..
- Assume c1 has 3 values [v1, v2, v3]
- The generated code will create a new VarcharHolder instance for each
value iteration
- For v1: VarCharHolder vc1 is created, ascii-mode computed for pattern1,
ascii-mode computation reused for pattern2, pattern3, etc since we're
evaluating the same value
- For v2: VarCharHolder vc1 is created, ascii-mode computed for pattern1,
ascii-mode computation reused for pattern2, pattern3, etc since we're
evaluating the same value
- DITO for v3
Note that the test-suite has similar test cases that you are proposing;
they all passed.
---
