Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r145790506
  
    --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
    @@ -908,6 +908,15 @@ public void generateTestData(int count) {
         }
     
       <#else> <#-- type.width <= 8 -->
    +    @Override
    +    public void add(Object value) {
    +      int index = accessor.getValueCount();
    +      int valueCount = index + 1;
    +      setValueCount(valueCount);
    +
    +      set(index, (${type.javaType}) value);
    --- End diff --
    
    All the issues with this make sense. I should have deleted this when I 
switched to using the RowSet classes, but forgot too :). Removing this now.


---

Reply via email to