Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/904#discussion_r147582266
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateFunctions.java
 ---
    @@ -34,19 +33,22 @@
     import org.apache.drill.exec.server.RemoteServiceSet;
     import org.apache.drill.exec.vector.ValueVector;
     import org.joda.time.LocalDate;
    -import org.joda.time.LocalTime;
     import org.joda.time.LocalDateTime;
    +import org.joda.time.LocalTime;
     import org.junit.Ignore;
     import org.junit.Test;
    -
     import com.google.common.base.Charsets;
     import com.google.common.io.Files;
     import org.junit.experimental.categories.Category;
     
    +import java.util.Locale;
    +
    +
     @Category({UnlikelyTest.class, SqlFunctionTest.class})
     public class TestDateFunctions extends PopUnitTestBase {
    --- End diff --
    
    This class has 4 space indentation, but according to our convention, it 
should be with 2 spaces. Since you have made changes here, could you please 
make 2 spaces indentation?



---

Reply via email to