Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/978#discussion_r148153093
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContextImpl.java
---
@@ -98,37 +70,25 @@ public boolean isClosed() {
@Override
public void close() {
if (closed) {
- logger.debug("Attempted to close Operator context for {}, but
context is already closed", popConfig != null ? popConfig.getClass().getName()
: null);
+ logger.debug("Attempted to close Operator context for {}, but
context is already closed", popConfig != null ? getName() : null);
return;
}
- logger.debug("Closing context for {}", popConfig != null ?
popConfig.getClass().getName() : null);
+ logger.debug("Closing context for {}", popConfig != null ? getName() :
null);
closed = true;
--- End diff --
`closed = true` should happen after the call to `super.close()` since base
class close can throw exception.
---
