GitHub user ilooner opened a pull request:
https://github.com/apache/drill/pull/1023
DRILL-5922 Fixed Child Allocator Lead. DRILL-5926 Stabalize TestValueVector
tests.
##DRILL-5922
- QueryContext was never closed when the Foreman finished. So the query
child allocator was never closed.
- The PlanSplitter created a QueryContext temporarily to construct an RPC
message but never closed it.
- The waitForExit method was error prone. Changed it to use the standard
condition variable pattern.
##DRILL-5926
The TestValueVector tests would run out of memory. I simple increased the
MaxDirectMemorySize for the forked test processes in the pom to avoid this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner/drill DRILL-5922
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1023.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1023
----
commit f4058a93e70b21328f1f06e1e1ede5451d00b499
Author: Timothy Farkas <[email protected]>
Date: 2017-11-02T18:27:56Z
- Deleted commented out code in unit test
commit 56fd6929d3ef738e1d756c067e4e4f80cf965e37
Author: Timothy Farkas <[email protected]>
Date: 2017-11-02T20:34:47Z
- Removed non-existant parameter from java docs
commit a32c3bed4cf52f15bcf2d0e284c04329827b32b7
Author: Timothy Farkas <[email protected]>
Date: 2017-11-03T16:11:04Z
- Initial attempt at fix
commit c0afcc8853e4449ec5d7de6dfeee51efc8ad70ab
Author: Timothy Farkas <[email protected]>
Date: 2017-11-03T18:19:08Z
- Fixed hanging unit tests
commit d1cd5672e1da1553b0d8cf94c5b3c47354d417a3
Author: Timothy Farkas <[email protected]>
Date: 2017-11-03T18:28:47Z
- More wait to exit improvements
commit ce3a9555482b02a19579c2388a65c4dd29353588
Author: Timothy Farkas <[email protected]>
Date: 2017-11-03T19:14:24Z
- Deleted unused logger
- Increased direct memory to prevent TestValueVector tests from running
out of memory
----
---
