Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1024#discussion_r149278719
  
    --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java 
---
    @@ -61,55 +71,129 @@ public static void tearDownStatement() throws 
SQLException {
       //////////
       // getQueryTimeout():
     
    -  /** Tests that getQueryTimeout() indicates no timeout set. */
    +  /**
    +   * Test for reading of default query timeout
    +   */
       @Test
    -  public void testGetQueryTimeoutSaysNoTimeout() throws SQLException {
    -    assertThat( statement.getQueryTimeout(), equalTo( 0 ) );
    +  public void testDefaultGetQueryTimeout() throws SQLException {
    +    Statement stmt = connection.createStatement();
    --- End diff --
    
    same comment as for `PreparedStatementTest` regarding closing statement


---

Reply via email to