Github user prasadns14 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1020#discussion_r149972346
--- Diff: exec/java-exec/src/main/resources/rest/metrics/metrics.ftl ---
@@ -138,21 +154,14 @@
});
};
- function updateOthers(metrics) {
- $.each(["counters", "meters"], function(i, key) {
- if(! $.isEmptyObject(metrics[key])) {
- $("#" + key + "Val").html(JSON.stringify(metrics[key], null, 2));
- }
- });
- };
-
var update = function() {
$.get("/status/metrics", function(metrics) {
updateGauges(metrics.gauges);
updateBars(metrics.gauges);
if(! $.isEmptyObject(metrics.timers)) createTable(metrics.timers,
"timers");
if(! $.isEmptyObject(metrics.histograms))
createTable(metrics.histograms, "histograms");
- updateOthers(metrics);
+ if(! $.isEmptyObject(metrics.counters))
createCountersTable(metrics.counters);
+ if(! $.isEmptyObject(metrics.meters))
$("#metersVal").html(JSON.stringify(metrics.meters, null, 2));
--- End diff --
@arina-ielchiieva,
I have considered reusing existing methods before deciding to have a
separate method.
With the above suggestion, the table will now look as below-
drill.connections.rpc.control.encrypted | {count: 0}
'|' here is column delimiter. Do we want to display only the number in the
second column or a key/value pair?
I just wanted it to be consistent with the other metrics tables. (so I
print value.count)
Removed meters section.
---
