Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1025#discussion_r150331389
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
 ---
    @@ -795,6 +788,8 @@ private void generateComparisons(final 
ClassGenerator<?> g, final VectorAccessib
        * @param node Reference to the next record to copy from the incoming 
batches
        */
       private boolean copyRecordToOutgoingBatch(final Node node) {
    +    assert outgoingPosition < OUTGOING_BATCH_SIZE
    --- End diff --
    
    I added the assert to avoid possible errors during further code 
refactoring. As it is an assert that will not affect performance in production 
and there is another assert already, I'd prefer to keep it.


---

Reply via email to