[GitHub] drill pull request #1033: DRILL-5952: Implement "CREATE TABLE IF NOT EXISTS"

[arina-ielchiieva]

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1033#discussion_r150513171
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
 ---
    @@ -83,7 +84,20 @@ public PhysicalPlan getPlan(SqlNode sqlNode) throws 
ValidationException, RelConv
         final DrillConfig drillConfig = context.getConfig();
         final AbstractSchema drillSchema = resolveSchema(sqlCreateTable, 
config.getConverter().getDefaultSchema(), drillConfig);
     
    -    checkDuplicatedObjectExistence(drillSchema, originalTableName, 
drillConfig, context.getSession());
    +    String schemaPath = drillSchema.getFullSchemaName();
    +
    +    // Check duplicate object existence
    +    boolean isTemporaryTable = 
context.getSession().isTemporaryTable(drillSchema, drillConfig, 
originalTableName);
    --- End diff --
    
    1. Please add unit tests for temp tables as well in `TestCTTAS` class.
    2. Should we consider similar functionality for views?


---