[GitHub] drill pull request #921: DRILL-4286 Graceful shutdown of drillbit

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/921#discussion_r150974066
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/DrillbitContext.java 
---
    @@ -157,10 +157,29 @@ public DrillConfig getConfig() {
         return context.getConfig();
       }
     
    -  public Collection<DrillbitEndpoint> getBits() {
    +  public Collection<DrillbitEndpoint> getAvailableBits() {
         return coord.getAvailableEndpoints();
       }
     
    +  public Collection<DrillbitEndpoint> getBits() {
    +    return coord.getOnlineEndPoints();
    +  }
    +  
    +  public boolean isOnline(DrillbitEndpoint endpoint) { return 
endpoint.getState().equals(DrillbitEndpoint.State.ONLINE); }
    +
    +  public boolean isForemanOnline() {
    +    DrillbitEndpoint foreman = getEndpoint();
    +    Collection<DrillbitEndpoint> dbs = getAvailableBits();
    +    for( DrillbitEndpoint db : dbs) {
    +      if( db.getAddress().equals(foreman.getAddress()) && db.getUserPort() 
== foreman.getUserPort()) {
    --- End diff --
    
    `if( db...` --> `if (db...`
    
    Also, `for( Drillbit...` --> `for (Drillbit...`


---