Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r151493351
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -175,6 +193,21 @@ public WorkspaceSchema createSchema(List<String>
parentSchemaPath, SchemaConfig
return new WorkspaceSchema(parentSchemaPath, schemaName, schemaConfig);
}
+ public WorkspaceSchema createSchema(List<String> parentSchemaPath,
SchemaConfig schemaConfig, DrillFileSystem fs) throws IOException {
+ if (!accessible(fs)) {
--- End diff --
returning null then user could not even list this workspace, so they don't
know the existence of this workspace at all. I think that is a good access
control practice.
If users expect to see a workspace but could not see it, then they need to
figure out why by themselves.
---
