[GitHub] drill pull request #1033: DRILL-5952: Implement "CREATE TABLE IF NOT EXISTS"

[prasadns14]

Github user prasadns14 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1033#discussion_r152900897
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
 ---
    @@ -382,6 +382,9 @@ public int getInSubqueryThreshold() {
        * @return The sql with a ^ character under the error
        */
       static String formatSQLParsingError(String sql, SqlParserPos pos) {
    +    if (pos == null) {
    --- End diff --
    
    we throw parseException with custom messages at a couple of locations 
(parserImpls.ftl). Ex 
    1) when the query contains '*' as one of the fields in create table/view 
statement 
    2) when the create view query contains both replace and if-not-exists
    unlike a parse error, the above two instances don't have the SqlParserPos 
set and will throw NPE 


---