Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1050#discussion_r153388800
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java
 ---
    @@ -30,18 +30,24 @@
     public class WorkspaceConfig {
     
       /** Default workspace is a root directory which supports read, but not 
write. */
    -  public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", 
false, null);
    +  public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", 
false, null, false);
     
       private final String location;
       private final boolean writable;
       private final String defaultInputFormat;
    -
    +  private final Boolean allowAccessOutsideWorkspace; // allow access 
outside the workspace by default. This
    --- End diff --
    
    Yes it would, I believe. But we want the value to be `true` for backward 
compatibility. (This also addresses your next comment). So we need to know if 
the value is missing. Can only do that with a non primitive AFAIK.


---

Reply via email to