Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/1055#discussion_r155326676
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/testing/CountDownLatchInjectionImpl.java
---
@@ -41,8 +41,11 @@
private CountDownLatchInjectionImpl(@JsonProperty("address") final
String address,
@JsonProperty("port") final int port,
@JsonProperty("siteClass") final
String siteClass,
- @JsonProperty("desc") final String
desc) throws InjectionConfigurationException {
- super(address, port, siteClass, desc, 0, 1);
+ @JsonProperty("desc") final String
desc,
+ @JsonProperty("nSkip") final int
nSkip,
+ @JsonProperty("nFire") final int
nFire,
+ @JsonProperty("msPause") final Long
msPause) throws InjectionConfigurationException {
--- End diff --
long instead of Long? You will save a lot of unnecessary checking for null
---