Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r156179325
--- Diff:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
---
@@ -117,7 +116,7 @@ public MaprDBJsonRecordReader(MapRDBSubScanSpec
subScanSpec,
disableCountOptimization =
formatPluginConfig.disableCountOptimization();
setColumns(projectedColumns);
- unionEnabled =
context.getOptions().getOption(ExecConstants.ENABLE_UNION_TYPE);
+ unionEnabled =
context.getOptionSet().getOption(ExecConstants.ENABLE_UNION_TYPE);
--- End diff --
Kind of funny that you have converted all this code to use `OptionSet`. I
was in the process of deprecating that class since the `OptionManager` seemed
to work in tests. (The previous dependencies on the Drill server had been
removed.)
But, since you've done all this work, we might as well embrace `OptionSet`
as the read-only view of options used by fragments and operators.
`OptionManager` is used only by code that alters options.
---
