Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1066#discussion_r158258149
  
    --- Diff: exec/java-exec/src/main/codegen/data/Parser.tdd ---
    @@ -75,6 +72,26 @@
       implementationFiles: [
         "parserImpls.ftl"
       ]
    +
    +  # List of methods for parsing extensions to "CREATE [OR REPLACE]" calls.
    +  # Each must accept arguments "(SqlParserPos pos, boolean replace)".
    +  createStatementParserMethods: [
    --- End diff --
    
    Calcites `Parser.jj` uses these lists to extend existing functionality when 
desired methods specified inside it. If we did not specify these lists, java 
class `Parser.java` could not be generated and build would fail with the error:
    ```
    [ERROR] Failed to execute goal 
org.apache.drill.tools:drill-fmpp-maven-plugin:1.12.0-SNAPSHOT:generate 
(generate-fmpp) on project drill-java-exec: FMPP processing session failed.
    [ERROR] Caused by: freemarker.core.InvalidReferenceException: The following 
has evaluated to null or missing:
    [ERROR] ==> parser.createStatementParserMethods  [in template "Parser.jj" 
at line 881, column 6]
    ```


---

Reply via email to