Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1040#discussion_r158102763
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServerConstants.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.server.rest;
+
+/**
+ * Holds various constants used by WebServer components.
+ */
+public class WebServerConstants {
+ //private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(WebServerConstants.class);
--- End diff --
1. Removed logger.
2. I prefer to use class since interface is mostly used for defining a
service contract. If it's an interface then any class can implement it and will
get access to all the constants which might not be required. I have changed the
class to be final and made constructor private so that it can't be extended and
instantiated by mistake.
---
