Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1078#discussion_r160741771
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
 ---
    @@ -228,13 +236,16 @@ private boolean isHolisticExpression(RexCall call) {
         return false;
       }
     
    +  protected boolean inputRefToPush(RexInputRef inputRef) {
    --- End diff --
    
    This is intentionally made to be 'protected' for future extension.
    Right now, FindPartitionCondition use position based inputRef(using BitSet 
dirs) to mark which inputRef should be pushed. But in future, we may use name 
based policy to decide which one to push. 


---

Reply via email to