Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162246792
--- Diff: exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java
---
@@ -58,23 +55,24 @@
import com.google.common.collect.ImmutableList;
import com.google.common.io.Resources;
-public class PlanningBase extends ExecTest{
- //private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(PlanningBase.class);
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
--- End diff --
Suggestion. Do not depend on mocking in test. Design code so it works well
in tests without mocks. Resort to mocks only when absolutely necessary. That
is, we should be trying to do LESS mocking, not MORE.
This way, the same test code can be used in tools, ad-hoc tests and so on
without the JUnit machinery.
This is a philosophical discussion, and one that should have input from
more of the team.
---
