Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1107#discussion_r166384715
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinStatus.java
---
@@ -101,8 +101,12 @@ public final void resetOutputPos() {
}
public final boolean isOutgoingBatchFull() {
- Preconditions.checkArgument(outputPosition <= OUTPUT_BATCH_SIZE);
- return outputPosition == OUTPUT_BATCH_SIZE;
+ Preconditions.checkArgument(outputPosition <= outputRowCount);
+ return outputPosition == outputRowCount;
--- End diff --
Maybe be just a bit more paranoid? `outputPosition >= outputRowCount`?
And, while we're at it, maybe `outputRowCount` -> `targetOutputRowCount`?
To make clear that the value is our target, not the actual, current row count.
---
