[GitHub] drill pull request #1117: DRILL-6089 Removed ordering trait from HashJoin in...

[amansinha100]

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1117#discussion_r167442059
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/JoinPruleBase.java
 ---
    @@ -246,4 +246,17 @@ public RelNode convertChild(final DrillJoinRel join,  
final RelNode rel) throws
     
       }
     
    +  // DRILL-6089 make sure no collations are added to HashJoin
    +  public static RelTraitSet removeCollation(RelTraitSet traitSet, 
RelOptRuleCall call)
    --- End diff --
    
    Since this is static method, better to add it to PrelUtil class for general 
purpose use. 


---