Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1120#discussion_r167929421
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSortSpillWithException.java
---
@@ -59,6 +59,7 @@ public static void setup() throws Exception {
ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
.configProperty(ExecConstants.EXTERNAL_SORT_SPILL_THRESHOLD, 1) //
Unmanaged
.configProperty(ExecConstants.EXTERNAL_SORT_SPILL_GROUP_SIZE, 1)
// Unmanaged
+ .configProperty(ExecConstants.EXTERNAL_SORT_MAX_MEMORY, 10 * 1024
* 1024) //use less memory for sorting.
--- End diff --
Please insert a comment to this effect in the code. This is a regression
introduced when we added the memory floor feature. Explain that we need to turn
off the floor (or lower it) for this test case. Thanks.
---
