Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1113#discussion_r168699838
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryStateProcessor.java
---
@@ -125,20 +125,17 @@ public void cancel() {
case PREPARING:
case PLANNING:
case ENQUEUED:
- moveToState(QueryState.CANCELLATION_REQUESTED, null);
- return;
-
case STARTING:
case RUNNING:
- addToEventQueue(QueryState.CANCELLATION_REQUESTED, null);
- return;
+ moveToState(QueryState.CANCELLATION_REQUESTED, null);
--- End diff --
1. Your point makes sense. In this case could you please update java doc
for the `cancel` method to be consistent with new changes?
2. Maybe we should remove word `regression` from the commit message to
avoid confusion?
---
