Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1123#discussion_r168777217
  
    --- Diff: exec/java-exec/src/main/codegen/templates/MathFunctions.java ---
    @@ -67,7 +67,11 @@ private GMathFunctions(){}
       public static class ${func.className}${type.input} implements 
DrillSimpleFunc {
     
         @Param ${type.input}Holder in;
    +  <#if func.funcName == 'sqrt'>
    +    @Output Float8Holder out;
    --- End diff --
    
    Please add comment why we use float holder for sqrt function.


---

Reply via email to