Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1125#discussion_r169858105
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java 
---
    @@ -108,6 +108,12 @@
         public final float estElementCountPerArray;
         public final boolean isVariableWidth;
     
    +    public Map<String, ColumnSize> childColumnSizes = 
CaseInsensitiveMap.newHashMap();
    --- End diff --
    
    Nit: `children` might be shorter and simpler. It is clear that the children 
are sizes from the member type.


---

Reply via email to