For JDK 8, we've run through both unit tests & regression tests from [1] and have observed no issues - so i think we should get the fixes into 1.13.0 and claim support for JDK 8.
[1] https://github.com/mapr/drill-test-framework On Tue, Feb 27, 2018 at 9:46 AM, Aman Sinha <[email protected]> wrote: > Agree with Arina on JDK8 support..let's get through the last remaining > hurdles for this for 1.13 release. > Calcite in fact is dropping support for JDK 7 in their next release. They > are even looking ahead to JDK 9. > > For Drill-on-Yarn, I think ultimately it is at the discretion of the > release manager. My personal opinion is as long > as a committer (in this case Arina) feels comfortable with it, and given > that the functionality has been well-tested, > I am okay to include it. > > -Aman > > On Tue, Feb 27, 2018 at 8:51 AM, Arina Yelchiyeva < > [email protected]> wrote: > > > I want to include DRILL-6174. It has already passed code review. > > > > Regarding JDK8 support. Volodymyr Tkach is working on this issue. > Currently > > all unit tests have passed. Now he is working on enforcing Java 8 > (changes > > in travis.yml, drill-config.sh, pom.xml etc). > > > > Regarding Drill on Yarn, Salim has done code review. Failing Travis check > > is easy to fix. Tim has already proposed the solution (Paul just needs to > > add the dependency). > > I think its safe to include these changes in this release. They go in > > separate module and have no impact any existing functionality. Even if > > there are some flows, users will be able to give it a try and feedback in > > case of issues. > > > > On Tue, Feb 27, 2018 at 8:53 AM, Parth Chandra <[email protected]> > wrote: > > > > > There are two issues marked as blockers for 1.13.0 - > > > TPatch InfoKeySummaryReporterPStatusResolutionCreatedUpdatedDueFix > > > Version/s > > > Assignee > > > <https://issues.apache.org/jira/browse/DRILL-6185>[image: Bug] > > > <https://issues.apache.org/jira/browse/DRILL-6185> DRILL-6185 > > > <https://issues.apache.org/jira/browse/DRILL-6185> > > > > > > Error is displaying while accessing query profiles via the Web-UI > > > <https://issues.apache.org/jira/browse/DRILL-6185> > > > Anton Gozhiy > > > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=angozhiy> > > > [image: > > > Blocker] OPEN *Unresolved* 26/Feb/18 26/Feb/18 1.13.0 > > > <https://issues.apache.org/jira/issues/?jql=project+%3D+ > > > DRILL+AND+fixVersion+%3D+1.13.0> > > > Kunal > > > Khatua <https://issues.apache.org/jira/secure/ViewProfile.jspa? > > > name=kkhatua> > > > Actions > > > <https://issues.apache.org/jira/rest/api/1.0/issues/ > > > 13140915/ActionsAndOperations?atl_token=A5KQ-2QAV-T4JA-FDED| > > > 582202a248949006c997dc02e0361c023d2c491d|lin> > > > <https://issues.apache.org/jira/browse/DRILL-1491>[image: Task] > > > <https://issues.apache.org/jira/browse/DRILL-1491> DRILL-1491 > > > <https://issues.apache.org/jira/browse/DRILL-1491> > > > > > > Support for JDK 8 <https://issues.apache.org/jira/browse/DRILL-1491> > > > Aditya Kishore > > > <https://issues.apache.org/jira/secure/ViewProfile.jspa? > > name=adityakishore > > > > > > > [image: > > > Blocker] OPEN *Unresolved* 03/Oct/14 22/Feb/18 1.13.0 > > > <https://issues.apache.org/jira/issues/?jql=project+%3D+ > > > DRILL+AND+fixVersion+%3D+1.13.0> > > > Volodymyr > > > Tkach > > > <https://issues.apache.org/jira/secure/ViewProfile.jspa? > > > name=volodymyr.tkach> > > > Actions > > > <https://issues.apache.org/jira/rest/api/1.0/issues/ > > > 12745818/ActionsAndOperations?atl_token=A5KQ-2QAV-T4JA-FDED| > > > 582202a248949006c997dc02e0361c023d2c491d|lin> > > > > > > DRILL-6185 is definitely a blocker. We cannot do a release with a UI > > > regression. > > > > > > From a quick perusal of DRILL-1491, JDK-8 support has issues that no > one > > is > > > looking at. Is someone addressing these and JIRA has not been updated? > > > > > > Also, - Drill 1170: Drill-on-YARN #1011, is failing Travis checks. > Call > > me > > > paranoid but a 21K line PR with one review comment doesn't sound like > the > > > review is completed. Any committer looking at it? > > > > > > > > > > > > > > > On Tue, Feb 27, 2018 at 9:28 AM, Ted Dunning <[email protected]> > > > wrote: > > > > > > > There is a pcap improvement about to be ready. And a bug (with a fix) > > > that > > > > just turned up. I will push for a PR > > > > > > > > On Feb 23, 2018 00:14, "Parth Chandra" <[email protected]> wrote: > > > > > > > > > Bit of a tepid response from dev; but Aman's approval is all the > > > > > encouragement I need to roll out a release :) > > > > > > > > > > Thoughts on pending PRs? > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Feb 22, 2018 at 9:54 PM, Aman Sinha <[email protected]> > > > > wrote: > > > > > > > > > > > Agreed...it would be good to get the ball rolling on the 1.13.0 > > > > release. > > > > > > Among other things, this release > > > > > > has the long pending Calcite rebase changes and the sooner we get > > it > > > it > > > > > out > > > > > > for users, the better. > > > > > > > > > > > > Thanks for volunteering ! > > > > > > > > > > > > -Aman > > > > > > > > > > > > On Wed, Feb 21, 2018 at 9:03 PM, Parth Chandra < > [email protected]> > > > > > wrote: > > > > > > > > > > > > > Hello Drillers, > > > > > > > > > > > > > > I feel we might benefit from a early release for 1.13.0. We > > took > > > > > longer > > > > > > > to do the previous release so it would be nice to bring the > > release > > > > > train > > > > > > > back on track. > > > > > > > > > > > > > > I'll volunteer (!) to manage the release :) > > > > > > > > > > > > > > What do you guys think? > > > > > > > > > > > > > > If we are in agreement on starting the release cycle and > there > > > are > > > > > any > > > > > > > issues on which work is in progress, that you feel we *must* > > > include > > > > in > > > > > > the > > > > > > > release, please post in reply to this thread. Let's at least > get > > a > > > > head > > > > > > > start on closing pending PRs since these are usually what > delays > > > > > > releases. > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > Parth > > > > > > > > > > > > > > > > > > > > > > > > > > > >
