I will take a look On Feb 27, 2018 8:47 PM, "Kunal Khatua" <[email protected]> wrote:
> Ted > > I suspected you needed a rebase, but I confirmed that your commit's parent > is the latest Master. > > For DRILL-6190 ( https://travis-ci.org/apache/drill/builds/346839630?utm_ > source=github_status&utm_medium=notification ) > the failure points to testDistinctQuery : ( https://api.travis-ci.org/v3/ > job/346839631/log.txt ).. expected result didn't match. > > Total record count: 2 16:15:12.576 [main] ERROR > org.apache.drill.TestReporter - Test Failed (d: 0 B(1 B), h: 371.1 > MiB(851.6 MiB), nh: 434.6 KiB(104.5 MiB)): testDistinctQuery(org.apache. > drill.exec.store.pcap.TestPcapRecordReader) java.lang.AssertionError: > expected:<1> but was:<2> at org.apache.drill.exec.store. > pcap.TestPcapRecordReader.printResultAndVerifyRowCount(TestPcapRecordReader.java:68) > ~[test-classes/:na] at org.apache.drill.exec.store. > pcap.TestPcapRecordReader.runSQLVerifyCount(TestPcapRecordReader.java:56) > ~[test-classes/:na] at org.apache.drill.exec.store. > pcap.TestPcapRecordReader.testDistinctQuery(TestPcapRecordReader.java:51) > ~[test-classes/:na] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) ~[na:1.7.0_151] at java.lang.reflect.Method.invoke(Method.java:606) > ~[na:1.7.0_151] at java.lang.reflect.Method.invoke(Method.java:606) > ~[na:1.7.0_151] at java.util.concurrent.FutureTask.run(FutureTask.java:262) > ~[na:1.7.0_151] at java.lang.Thread.run(Thread.java:748) ~[na:1.7.0_151] > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.404 sec > <<< FAILURE! - in org.apache.drill.exec.store.pcap.TestPcapRecordReader > testDistinctQuery(org.apache.drill.exec.store.pcap.TestPcapRecordReader) > Time elapsed: 1.382 sec <<< FAILURE! java.lang.AssertionError: expected:<1> > but was:<2> at org.apache.drill.exec.store.pcap.TestPcapRecordReader. > printResultAndVerifyRowCount(TestPcapRecordReader.java:68) at > org.apache.drill.exec.store.pcap.TestPcapRecordReader.runSQLVerifyCount(TestPcapRecordReader.java:56) > at org.apache.drill.exec.store.pcap.TestPcapRecordReader. > testDistinctQuery(TestPcapRecordReader.java:51) > > For DRILL-6191 (https://travis-ci.org/apache/drill/builds/346839917?utm_ > source=github_status&utm_medium=notification), I see that your unit test > failed because of a likely memory leak. > Full text: https://api.travis-ci.org/v3/job/346839918/log.txt > org.apache.drill.exec.store.pcap.TestPcapRecordReader Time elapsed: 4.201 > sec <<< ERROR! java.lang.RuntimeException: Exception while closing at > org.apache.drill.common.DrillAutoCloseables.closeNoChecked(DrillAutoCloseables.java:46) > at org.apache.drill.exec.client.DrillClient.close(DrillClient.java:459) > at org.apache.drill.test.BaseTestQuery.closeClient(BaseTestQuery.java:287) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at > java.lang.reflect.Method.invoke(Method.java:606) at > java.lang.reflect.Method.invoke(Method.java:606) at > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:113) > at org.apache.maven.surefire.junitcore.JUnitCoreWrapper. > executeEager(JUnitCoreWrapper.java:85) at org.apache.maven.surefire. > junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:54) at > org.apache.maven.surefire.junitcore.JUnitCoreProvider. > invoke(JUnitCoreProvider.java:134) at org.apache.maven.surefire. > booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) > at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) > Caused by: java.lang.IllegalStateException: Allocator[ROOT] closed with > outstanding buffers allocated (1). Allocator(ROOT) > 0/65536/131072/4831838208 (res/actual/peak/limit) child allocators: 0 > ledgers: 1 > > So the Travis system seems to be working fine. Could you check the test > for 6190 and see if 6191 has a possible leak ? > > On 2/27/2018 5:36:56 PM, Timothy Farkas <[email protected]> wrote: > Can you give an link to your PR or Travis build logs? Also have you > rebased onto the latest master? > > Thanks, > Tim > > ________________________________ > From: Ted Dunning > Sent: Tuesday, February 27, 2018 2:53:37 PM > To: [email protected] > Subject: Re: travis CI? > > Yeah... Did all that. > > But these are the tests that are listed as failing and this doesn't make > any sense: > > 16:15:12.560 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0 > B(1 B), h: 2.3 MiB(456.1 MiB), nh: 8.6 KiB(99.8 MiB)): > checkValidationException(org.apache.drill.exec.server.TestOptions) > 16:15:13.269 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0 > B(1 B), h: 5.7 MiB(521.4 MiB), nh: 32.5 KiB(100.0 MiB)): > unsupportedLiteralValidation(org.apache.drill.exec.server.TestOptions) > 16:19:12.035 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0 > B(128.0 KiB), h: 5.8 MiB(703.8 MiB), nh: 0 B(136.1 MiB)): > testMissingOverWithConstant(org.apache.drill.exec.TestWindowFunctions) > 16:19:14.598 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0 > B(128.0 KiB), h: 3.9 MiB(1.3 GiB), nh: 0 B(137.4 MiB)): > testWindowInWindow(org.apache.drill.exec.TestWindowFunctions) > 16:19:17.354 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0 > B(128.0 KiB), h: 6.6 MiB(1.0 GiB), nh: 0 B(138.3 MiB)): > testWindowGroupBy(org.apache.drill.exec.TestWindowFunctions) > 16:19:18.984 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0 > B(128.0 KiB), h: 4.1 MiB(615.4 MiB), nh: 0 B(138.7 MiB)): > testLeadMissingOver(org.apache.drill.exec.TestWindowFunctions) > 16:19:20.694 [main] ERROR org.apache.drill.TestReporter - Test Failed (d: 0 > B(128.0 KiB), h: 3.4 MiB(1000.0 MiB), nh: 576 B(139.0 MiB)): > testMissingOverWithWindowClause(org.apache.drill.exec.TestWindowFunctions) > > > None of this code was even remotely touched by either of two independent > changes. > > > > On Tue, Feb 27, 2018 at 11:24 AM, Timothy Farkas wrote: > > > Hi Ted, > > > > The Travis build works. If there is a green check the build succeeded. If > > there is a red X it failed. At this point with the latest master the > build > > is stable, so if the Travis build fails you probably broke something. To > > see the results of a travis build for a PR: > > > > > > 1. Go to your PR page > > 2. Go to the bottom and click show all checks > > 3. Click details next to Travis. > > 4. This will take you to the Travis page with trimmed down logs > > 5. To see full logs click Raw logs > > 6. To see the tests that fail scroll down to the bottom and look at the > > Maven test summary. > > > > > > Some of the tests do print stack traces when they are passing and working > > correctly. I agree it's annoying but the Maven test summary will give you > > an accurate list of failed tests. > > > > Thanks, > > Tim > > > > ________________________________ > > From: Ted Dunning > > Sent: Tuesday, February 27, 2018 11:09:43 AM > > To: [email protected] > > Subject: travis CI? > > > > Does the travis CI build actually work? > > > > How can you tell what broke? There seem to be bunches of tests that print > > out stack traces, but actually succeed. > > > > Is there a way to access the test output file? > > >
